Dear WPForo team,

Trying to resolve an issue with MultiSite user registration activation (see this post in the forum), I noticed something that may be a bug or not. Please correct me if I'm wrong.

For MultiSite users, and email activation enabled, the function wpmu_signup_user should be used.
This creates an entry in wp_signups and send an activation email to the user.
Once the user clicks the activation link in this email, the user will be added to the users tabel wp_users.

However, with the current WPForo version (1.9.3) the function register_new_user is being used which right away adds the user to wp_users and does not send an activation email an there will be no entry in wp_signups - the new user can never activate his or her account.

Modifying the original code of a plugin is not something I can recommend to anyone, but while testing this on my test server the following changes worked by modifying wpforo/wpf-includes/class-members.php around line 263 where you'll find:

$user_id = register_new_user( $user_fields['user_login'], $user_fields['user_email'] );
if ( !is_wp_error( $user_id ) && $user_id ) {
  do_action( 'wpforo_create_user_after', $data );
  WPF()->notice->clear();
  WPF()->notice->add('Success! Please check your mail for confirmation.', 'success');
  return $user_id;
}

I've modified the code to this for testing:

if( is_multisite() ) {
  wpmu_signup_user($user_fields['user_login'], $user_fields['user_email']);
  WPF()->notice->clear();
  WPF()->notice->add('Success! Please check your mail for confirmation.', 'success'); 
  return TRUE;
} else { 
  $user_id = register_new_user( $user_fields['user_login'], $user_fields['user_email'] );
  if ( !is_wp_error( $user_id ) && $user_id ) {
    do_action( 'wpforo_create_user_after', $data );
    WPF()->notice->clear();
    WPF()->notice->add('Success! Please check your mail for confirmation.', 'success');
    return $user_id;
  }
}

And now User signup with email activation works correct on my WP Multisite setup.

Please correct me if I'm wrong - I'm not a coding expert and most certainly will not claim to know much about the inner workings of WPForo.